Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some of the changed files #94

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Exclude some of the changed files #94

merged 1 commit into from
Aug 9, 2024

Conversation

hkdobrev
Copy link
Owner

@hkdobrev hkdobrev commented Aug 9, 2024

Exclude changed files detected from Git if:

  • they have been deleted and not in the worktree
  • they are changed in submodules

Both of these scenarios have some valid use cases for running commands on changes. E.g. refreshing a build after deleting files.
However, they are rare. E.g.:

  • If a file the command expects is now missing, the command may fail.
  • If a submodule is changed, a command might run unnecessarily.

⚠️ If there are users who would like these changes to still trigger command run, I think it's best done behind a configuration.
👉 But the default behaviour should not be surprising and all of the use cases in the readme describe cases where these changes should not trigger command runs.

@hkdobrev hkdobrev added the enhancement New feature or request label Aug 9, 2024
@hkdobrev hkdobrev self-assigned this Aug 9, 2024
@hkdobrev hkdobrev requested a review from MartinAndreev August 9, 2024 21:39
@hkdobrev hkdobrev merged commit a59bd5a into main Aug 9, 2024
3 checks passed
@hkdobrev hkdobrev deleted the git-filter branch August 9, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants