Auto backlight logic #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
display backlight logic fix as we need to check v["I2C"]["light"] first set brightness
type
hishizuka
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
2nd part from the display-conf refactor:
I think it keeps the actual logic well (the looping over the brightness table + auto backlight setting).
I've removed the scripts for piTfT, no need for manually copying script (though the set brightness 0 will happen before in the shutdown process)
I've noticed that set_brightness for MIP does check for current brightness status in python code, but not in cpp. the code should be aligned (either doing in both or removing it from the python code)
drop g_quit
display backlight logic
fix as we need to check v["I2C"]["light"] first (for ant+ light)