Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft/introduction to react router #2

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from

Conversation

hirwaaldo1
Copy link
Owner

This PR covers the following content (from scrimba).

  1. Introduction to React Router 6
  2. Multi-page vs single-page apps
  3. React Router Setup & BrowserRouter
  4. Routes
  5. BrowserRouter & Routes challenge
  6. Route, path, & element
  7. Quick Re.org
  8. Link
  9. VanLife project bootstrapping
  10. Initial Deploy to Netlify
  11. Mirage JS Server
  12. Challenge: Vans Page - Part 1
  13. Challenge: Vans Page - Part 2
  14. Route Params - part 1
  15. Route Params - part 2
  16. Route Params part 3.1 - useParams() & challenge
  17. Route Params part 3.2 - useParams() challenge
  18. Route Params Quiz

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for a-van ready!

Name Link
🔨 Latest commit 6e44935
🔍 Latest deploy log https://app.netlify.com/sites/a-van/deploys/643fbac4e681170008eace41
😎 Deploy Preview https://deploy-preview-2--a-van.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hirwaaldo1 hirwaaldo1 added the Ready for code review Ready for any one who want to review label Apr 6, 2023
Copy link

@mercihabam mercihabam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations

You did a great job, however, you should look at the few comments I left below to improve your code.

src/App.jsx Outdated Show resolved Hide resolved
src/main.jsx Outdated Show resolved Hide resolved
src/pages/Vans/Detail.jsx Outdated Show resolved Hide resolved
src/pages/Vans/index.jsx Outdated Show resolved Hide resolved
@hirwaaldo1 hirwaaldo1 added Done Done and removed Ready for code review Ready for any one who want to review labels Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants