-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript declarations #336
Add TypeScript declarations #336
Conversation
|
Thanks for the PR @vsund! We will discuss this at the next engineering meeting. |
Just noticed that I originally branched it of This shouldn't change anything since we use We definitely should double-check this PR. |
Just for reference, I'm probably going to abandon this in favor of my Going to close this, can reopen if needed. |
I added TypeScript declarations to my fork some time ago. I talked with @jackzampolin about this and he said that I should add a PR to create a platform to discuss. Whether we merge this or not, I'd like to kick off a discussion about:
blockstack.js
?Todo
This PR isn't fully complete yet. Things still to do:
./src/profiles/index.d.ts
)tests/typescriptTests/index.ts
)./src/index.ts
./src/auth/index.d.ts
./src/auth/index.d.ts
./src/profiles/index.d.ts
./src/profiles/index.d.ts
any
types in the declaration files; need to revisit them to check if there are more precise return typescc @larrysalibra @jackzampolin