Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor nakamoto tests #1602

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Dec 8, 2023

This PR was published to npm with the version 6.9.1-pr.e2f95a8.0
e.g. npm install @stacks/[email protected] --save-exact

  • only test refactoring

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 0:26am

@janniks janniks changed the base branch from main to nakamoto December 8, 2023 11:55
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (25c821b) 66.31% compared to head (e2f95a8) 66.41%.
Report is 3 commits behind head on nakamoto.

Files Patch % Lines
packages/common/src/buffer.ts 41.66% 7 Missing ⚠️
packages/transactions/src/payload.ts 94.23% 3 Missing ⚠️
packages/transactions/src/transaction.ts 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           nakamoto    #1602      +/-   ##
============================================
+ Coverage     66.31%   66.41%   +0.09%     
============================================
  Files           119      119              
  Lines          8690     8745      +55     
  Branches       1914     1950      +36     
============================================
+ Hits           5763     5808      +45     
+ Misses         2802     2702     -100     
- Partials        125      235     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janniks janniks requested a review from zone117x December 13, 2023 15:46
@janniks janniks merged commit 60d75fa into nakamoto Dec 13, 2023
7 checks passed
@janniks janniks deleted the test/refactor-nakamoto-tests branch December 13, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants