build: fix circular dep issue (#1658)

packages/transactions/src/index.ts

@@ -100,4 +100,5 @@ export * from './signer';
 export * from './structuredDataSignature';
 export { StacksTransaction, deserializeTransaction } from './transaction';
 export * from './types';
+export * from './message-types';
 export * from './utils';

packages/transactions/src/keys.ts

@@ -38,7 +38,7 @@ import {
   UNCOMPRESSED_PUBKEY_LENGTH_BYTES,
 } from './constants';
 import { hash160, hashP2PKH } from './utils';
-import { StructuredDataSignature } from './structuredDataSignature';
+import { StructuredDataSignature } from './message-types';
 
 /**
  * To use secp256k1.signSync set utils.hmacSha256Sync to a function using noble-hashes

packages/transactions/src/message-types.ts

@@ -0,0 +1,8 @@
+// todo: this file should hold the type definitions for more message types later
+// needed now to fix a circular dependency issue in structuredDataSignature
+import { StacksMessageType } from './constants';
+
+export interface StructuredDataSignature {
+  readonly type: StacksMessageType.StructuredDataSignature;
+  data: string;
+}

packages/transactions/src/structuredDataSignature.ts

@@ -4,6 +4,7 @@ import { bytesToHex, concatBytes, utf8ToBytes } from '@stacks/common';
 import { ClarityType, ClarityValue, serializeCV } from './clarity';
 import { StacksMessageType } from './constants';
 import { signMessageHashRsv, StacksPrivateKey } from './keys';
+import { StructuredDataSignature } from './message-types';
 
 // Refer to SIP018 https://github.com/stacksgov/sips/
 // > asciiToBytes('SIP018')
@@ -66,11 +67,6 @@ export function decodeStructuredDataSignature(
   };
 }
 
-export interface StructuredDataSignature {
-  readonly type: StacksMessageType.StructuredDataSignature;
-  data: string;
-}
-
 /**
  * Signs a structured message (ClarityValue) and a domain (ClarityValue) using a private key.
  * The resulting signature along with the original message can be verified using {@link verifyMessageSignature}