Allow xaxis column to be set. Allow suppression of invalid data columns #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you have an example of use case where the data has to be cleaned by highchartTable and not before, when generating the table ? For the data-graph-xaxis attribute, could you open a separate pull request to discuss that with exemples on jsfiddle ? |
|
@RikdeBoer any news on this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When somebody brought this plugin to my attention I immediately fell in live with it and simple had to write a Drupal module for it: http://drupal.org/project/highcharttable
When playing with it I felt two extensions would be really useful. They're both included with this single commit.
Allow the data-graph-xaxis="#" attribute to be specified on the table to specify as the horizontal axis a column other than the first, i.e. 0.
I found that Highchart does not cope very well when one of the series contains invalid data, like for instance a column of words, rather than numbers. Not only does that column not display, none of the valid numeric columns display either. The chart is blank. To avoid this this commit introduces datagraph-suppress-invalid-series="1" so that the chart will correctly display even when some of the columns contain invalid data.
I've marked my changes "RdB", but please feel free to remove those code comments.
I hope you agree with these changes and can create a new release soon.
Thanks again for all your work on this plugin.
Rik