Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.8 EOL #460

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Python3.8 EOL #460

merged 8 commits into from
Nov 22, 2024

Conversation

mbkumar
Copy link
Collaborator

@mbkumar mbkumar commented Nov 21, 2024

Python reached EOL in Oct 2024. This PR removes support for 3.8 and drops support for the pre-numpy2.0 style of installing numpy.

@mbkumar mbkumar requested a review from landreman November 21, 2024 16:10
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (9fc2c36) to head (6b29fdf).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files          78       78           
  Lines       14514    14514           
=======================================
  Hits        13450    13450           
  Misses       1064     1064           
Flag Coverage Δ
unittests 92.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@landreman
Copy link
Contributor

Looks fine, if you can fix the wheel action?

@mbkumar
Copy link
Collaborator Author

mbkumar commented Nov 22, 2024

@landreman Done.

@mbkumar mbkumar merged commit beaf7b2 into master Nov 22, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants