Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Minor Fix) two broken examples in docs #459

Merged
merged 4 commits into from
Nov 22, 2024
Merged

(Minor Fix) two broken examples in docs #459

merged 4 commits into from
Nov 22, 2024

Conversation

missing-user
Copy link
Contributor

Two examples in the documentation folder weren't working with the current simsopt version, because a .J was missing

@missing-user missing-user marked this pull request as draft November 21, 2024 15:16
@missing-user missing-user marked this pull request as ready for review November 21, 2024 15:18
@missing-user missing-user changed the title Fix two broken examples in docs (Minor Fix) two broken examples in docs Nov 21, 2024
@landreman landreman self-requested a review November 22, 2024 00:46
landreman
landreman approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@landreman landreman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@landreman landreman merged commit ae70638 into hiddenSymmetries:master Nov 22, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landreman landreman landreman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@missing-user @landreman