refactorings #3
Open
refactorings #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- This bug fix handles cases where user passes integer
input for phi or theta as in
>>> b.calculate_modB_boozer(4, [3, 2], [3, 4])
--make sure that the python subclass is imported by plots.
…into refactorings
-- This is done in `_calculate_fourier_series` and
`calculate_modB_boozer_on_surface`, for consistency.
- This action is recommended by numpy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out
calculate_modB_boozer_on_surfacefromplots.surfplotand makes it available as a python method for the Booz_xform class