Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phip fix #17

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Phip fix #17

merged 6 commits into from
Jul 30, 2024

Conversation

ejpaul
Copy link
Contributor

@ejpaul ejpaul commented Jul 26, 2024

This branch fixes a bug that was caused by #11, in which the poloidal flux was saved as the variable phip_b in the netcdf file. However, the toroidal flux derivative was saved with the same name in the STELLOPT version. The variable phip_b is now saved as the toroidal flux derivative, while the poloidal flux is saved as chi_b if read_wout is called with flux = True. The netcdf read error is handled in the case that chi_b is not written to the file. The pressure, pres, which is required for AE calculations, is also read from the wout file and saved in the netcdf file if flux = True.

src/_booz_xform/bindings.cpp Outdated Show resolved Hide resolved
src/_booz_xform/bindings.cpp Outdated Show resolved Hide resolved
src/_booz_xform/booz_xform.hpp Outdated Show resolved Hide resolved
src/_booz_xform/booz_xform.hpp Outdated Show resolved Hide resolved
@landreman landreman self-requested a review July 30, 2024 19:13
@landreman landreman merged commit 2ceb1d7 into main Jul 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants