Skip to content

Commit

Permalink
clang: allow build on Windows with Visual C++
Browse files Browse the repository at this point in the history
The CMake code will set HAVE_CLANG_REPL_SUPPORT to ON and the Visual C++
compiler will complain at linking a release build of clang-repl.exe due
to the number of symbols bigger than 65k.

This patchset allows setting HAVE_CLANG_REPL_SUPPORT to OFF and build
fine.

Change-Id: I10665ef13c7dfffb5e23c05475ac5f10de48b8ee
Reviewed-by: Eike Ziller <[email protected]>
  • Loading branch information
cristianadam committed Jan 6, 2025
1 parent 5c2bb6a commit 8af6d99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion clang/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ CMAKE_DEPENDENT_OPTION(CLANG_PLUGIN_SUPPORT
# If libstdc++ is statically linked, clang-repl needs to statically link libstdc++
# itself, which is not possible in many platforms because of current limitations in
# JIT stack. (more platforms need to be supported by JITLink)
if(NOT LLVM_STATIC_LINK_CXX_STDLIB)
if(NOT LLVM_STATIC_LINK_CXX_STDLIB AND NOT DEFINED HAVE_CLANG_REPL_SUPPORT)
set(HAVE_CLANG_REPL_SUPPORT ON)
endif()

Expand Down

0 comments on commit 8af6d99

Please sign in to comment.