wip: define only module factories

hi-ogawa · Dec 8, 2024 · 976d20f · 976d20f
1 parent ddc5461
commit 976d20f
Show file tree

Hide file tree

Showing 13 changed files with 27 additions and 38 deletions.
diff --git a/crates/rolldown/src/ecmascript/format/app.rs b/crates/rolldown/src/ecmascript/format/app.rs
@@ -25,7 +25,7 @@ pub fn render_app<'code>(
   }
 
   // chunk content
-  source_joiner.append_source("\n__rolldown_runtime.modules({\n");
+  source_joiner.append_source("var __rolldown_modules = {\n");
   module_sources.iter().for_each(|(_, module_id, module_render_output)| {
     source_joiner.append_source(format!(
       "{}: function(__rolldown_runtime) {{",
@@ -39,7 +39,7 @@ pub fn render_app<'code>(
     }
     source_joiner.append_source("},\n");
   });
-  source_joiner.append_source("});\n");
+  source_joiner.append_source("};\n");
 
   if let Some(outro) = outro {
     source_joiner.append_source(outro);

diff --git a/crates/rolldown/src/rebuild/mod.rs b/crates/rolldown/src/rebuild/mod.rs
@@ -70,7 +70,7 @@ impl RebuildManager {
     if !changed_modules.is_empty() {
       // create hmr chunk
       let mut source_joiner = SourceJoiner::default();
-      source_joiner.append_source("\n__rolldown_runtime.modules({\n");
+      source_joiner.append_source("\nvar __rolldown_modules = {\n");
       for (module_id, module) in &changed_modules {
         source_joiner.append_source(format!(
           "{}: function(__rolldown_runtime) {{",
@@ -81,7 +81,7 @@ impl RebuildManager {
         }
         source_joiner.append_source("},\n");
       }
-      source_joiner.append_source("});\n");
+      source_joiner.append_source("};\n");
       let (content, mut map) = source_joiner.join();
       let file_dir = options.cwd.as_path().join(&options.dir);
       if let Some(map) = map.as_mut() {

diff --git a/crates/rolldown/tests/rolldown/function/format/app/export-all/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/export-all/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "main.js": function(__rolldown_runtime) {
 //#region main.js

diff --git a/crates/rolldown/tests/rolldown/function/format/app/export-default-class/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/export-default-class/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "foo.js": function(__rolldown_runtime) {
 //#region foo.js

diff --git a/crates/rolldown/tests/rolldown/function/format/app/export-default-expr/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/export-default-expr/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "main.js": function(__rolldown_runtime) {
 //#region main.js

diff --git a/crates/rolldown/tests/rolldown/function/format/app/export-default-fn/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/export-default-fn/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "foo.js": function(__rolldown_runtime) {
 //#region foo.js

diff --git a/crates/rolldown/tests/rolldown/function/format/app/export-named-from/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/export-named-from/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "main.js": function(__rolldown_runtime) {
 //#region main.js

diff --git a/crates/rolldown/tests/rolldown/function/format/app/export-named/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/export-named/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "main.js": function(__rolldown_runtime) {
 //#region main.js

diff --git a/crates/rolldown/tests/rolldown/function/format/app/import/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/import/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "rolldown:runtime": function(__rolldown_runtime) {
 

diff --git a/crates/rolldown/tests/rolldown/function/format/app/multiple_entry_modules/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/multiple_entry_modules/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## cube.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "square.js": function(__rolldown_runtime) {
 //#region square.js
@@ -39,8 +38,7 @@ function cube(x) {
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "hyper-cube.js": function(__rolldown_runtime) {
 //#region hyper-cube.js
@@ -69,8 +67,7 @@ console.log(hyper_cube_exports.default(5));
 ## other-entry.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "other-entry.js": function(__rolldown_runtime) {
 //#region other-entry.js

diff --git a/crates/rolldown/tests/rolldown/function/format/app/require/artifacts.snap b/crates/rolldown/tests/rolldown/function/format/app/require/artifacts.snap
@@ -7,8 +7,7 @@ snapshot_kind: text
 ## main.js
 
 ```js
-
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "rolldown:runtime": function(__rolldown_runtime) {
 

diff --git a/crates/rolldown/tests/rolldown/rebuild/basic/artifacts.snap b/crates/rolldown/tests/rolldown/rebuild/basic/artifacts.snap
@@ -38,7 +38,7 @@ console.log(dep);
 
 ```js
 
-__rolldown_runtime.modules({
+var __rolldown_modules = {
 
 "dep.js": function(__rolldown_runtime) {
 //#region dep.js

diff --git a/crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap b/crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap
@@ -4127,41 +4127,41 @@ snapshot_kind: text
 
 # tests/rolldown/function/format/app/export-all
 
-- main-!~{000}~.js => main-C8JyO0Pq.js
+- main-!~{000}~.js => main-C2fhg46c.js
 
 # tests/rolldown/function/format/app/export-default-class
 
-- main-!~{000}~.js => main-B7y_NdJ7.js
+- main-!~{000}~.js => main-XV6nvXr2.js
 
 # tests/rolldown/function/format/app/export-default-expr
 
-- main-!~{000}~.js => main-DxPlJBbf.js
+- main-!~{000}~.js => main-Bi9MTw2b.js
 
 # tests/rolldown/function/format/app/export-default-fn
 
-- main-!~{000}~.js => main-CpWZgeg3.js
+- main-!~{000}~.js => main-DyhDAcZw.js
 
 # tests/rolldown/function/format/app/export-named
 
-- main-!~{000}~.js => main-DtsEkgbw.js
+- main-!~{000}~.js => main-DOoEzyUq.js
 
 # tests/rolldown/function/format/app/export-named-from
 
-- main-!~{000}~.js => main-DHIOi3Lr.js
+- main-!~{000}~.js => main-BA7Qc7Uu.js
 
 # tests/rolldown/function/format/app/import
 
-- main-!~{000}~.js => main-DKZyN37s.js
+- main-!~{000}~.js => main-BLlCw-xy.js
 
 # tests/rolldown/function/format/app/multiple_entry_modules
 
-- main-!~{000}~.js => main-AkAKQngF.js
-- other-entry-!~{001}~.js => other-entry-Cnlk6n3p.js
-- cube-!~{002}~.js => cube-Beuobi3z.js
+- main-!~{000}~.js => main-DAXIiw9l.js
+- other-entry-!~{001}~.js => other-entry-D3MxylU_.js
+- cube-!~{002}~.js => cube-CmpNDwx8.js
 
 # tests/rolldown/function/format/app/require
 
-- main-!~{000}~.js => main-BFFsZQki.js
+- main-!~{000}~.js => main-8xgU3A1-.js
 
 # tests/rolldown/function/format/cjs/conflict_exports_key