Multi-transfer #23
Draft
Multi-transfer #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hex337
reviewed
Sep 21, 2021
| reason := parsedResult["reason"] | ||
| splitAmounts := splitCoins(totalAmount, len(toUserIds)) | ||
|
|
||
| for i, toUserId := range toUserIds { |
There was a problem hiding this comment.
Is there a way to wrap this in a transaction? I'm just worried that if someone spams a few transfers and these are going one at a time, that we end up in a bad state.
There was a problem hiding this comment.
good point, I actually tried to move all the validation part to the beginning of the method, to reduce the possibility of partial transfer, but might be worth to just use a transaction wrapper, will take a look of the support of GORM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer to multiple persons