Merge branch 'release-2.0.0' into develop

herzbube · Jan 3, 2024 · 7ccfaad · 7ccfaad
2 parents cc4a186 + 392f643
commit 7ccfaad
Show file tree

Hide file tree

Showing 42 changed files with 77 additions and 42 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -21,7 +21,7 @@ project (
   # The project version.
   # Sets PROJECT_VERSION, PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR,
   # PROJECT_VERSION_PATCH and PROJECT_VERSION_TWEAK.
-  VERSION 1.0
+  VERSION 2.0.0
 
   # Some informational package metadata. Not necessary for the build.
   # Sets PROJECT_HOMEPAGE_URL and PROJECT_DESCRIPTION

diff --git a/NOTICE b/NOTICE
@@ -1,5 +1,5 @@
 libsgfc++
-Copyright 2020-2021 Patrick Näf ([email protected])
+Copyright 2020-2024 Patrick Näf ([email protected])
 
 This product uses the source code provided by the SGFC command line utility to
 read, parse and write SGF data. SGFC was developed by Arno Hollosi

diff --git a/doc/ChangeLog.md b/doc/ChangeLog.md
@@ -1,5 +1,40 @@
 # ChangeLog
 
+## Version 2.0.0 (January 3 2024)
+
+### Features
+
+- None
+
+### Bugfixes
+
+- Fixed numeric value of `SgfcMessageID::IllegalVariationStartCorrected` (#39). The enum value had the same numeric value as `SgfcMessageID::IllegalVariationStartIgnored`.
+- Changed the value type for referencing line and column numbers in messages to `unsigned long`, to match the error reporting interface of SGFC (#40). The old type `int` was insufficient to hold all possible `unsigned long` values, also the there was a signed/unsigned mismatch. The change affects the `ISgfcMessage` getters `GetLineNumber()` and `GetColumnNumber()`, as well as the constants `SgfcConstants::InvalidLineNumber` and `SgfcConstants::InvalidColumnNumber`. The constants also changed their value (previously -1, now 0).
+
+### Regressions
+
+- None
+
+### Technical changes
+
+- Replaced internal custom code to determine the path to a temporary folder with `std::filesystem::temp_directory_path()` (#18).
+- Updated unit test library Catch2 from v2.13.4 to v3.5.0.
+- Updated the [Cross-compiling for iOS](Build.md#cross-compiling-for-ios) documentation for modern CMake/Xcode versions.
+- Updated the GitHub build pipelines.
+
+### GitHub issue list
+
+A list of all issues closed for this release is available [on GitHub](https://github.com/herzbube/libsgfcplusplus/milestone/4?closed=1)
+
+
+## Version 1.0 (February 23 2021)
+
+Initial 1.0 release that includes SGFC v2.0.
+
+## Version 0.2 (beta) (January 12 2021)
+
+Release of version 0.2 (beta).
+
 ## Version 0.1 (alpha) (October 11 2020)
 
 Release of version 0.1 (alpha).

diff --git a/include/ISgfcMessage.h b/include/ISgfcMessage.h
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/include/SgfcConstants.h b/include/SgfcConstants.h
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/include/SgfcMessageID.h b/include/SgfcMessageID.h
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/src/SgfcConstants.cpp b/src/SgfcConstants.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -24,7 +24,7 @@
 namespace LibSgfcPlusPlus
 {
   const std::string SgfcConstants::LibraryName = "libsgfc++";
-  const std::string SgfcConstants::LibraryVersion = "1.0";
+  const std::string SgfcConstants::LibraryVersion = "2.0.0";
   const std::string SgfcConstants::SgfcVersion = "2.0";
 
   // SgfcMessage line and column numbers are 1-based, so value 0 (zero) can be

diff --git a/src/SgfcUtility.cpp b/src/SgfcUtility.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/src/SgfcUtility.h b/src/SgfcUtility.h
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/src/sgfc/frontend/SgfcDocumentReadResult.cpp b/src/sgfc/frontend/SgfcDocumentReadResult.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/src/sgfc/frontend/SgfcDocumentWriteResult.cpp b/src/sgfc/frontend/SgfcDocumentWriteResult.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/src/sgfc/message/SgfcMessage.cpp b/src/sgfc/message/SgfcMessage.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/src/sgfc/message/SgfcMessage.h b/src/sgfc/message/SgfcMessage.h
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/src/sgfc/message/SgfcMessageStream.cpp b/src/sgfc/message/SgfcMessageStream.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/AssertHelperFunctions.cpp b/test/AssertHelperFunctions.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/document/SgfcDocumentTest.cpp b/test/document/SgfcDocumentTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/document/SgfcGameTest.cpp b/test/document/SgfcGameTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/document/SgfcNodeTest.cpp b/test/document/SgfcNodeTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/document/SgfcNodeTraitsTest.cpp b/test/document/SgfcNodeTraitsTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/document/SgfcTreeBuilderTest.cpp b/test/document/SgfcTreeBuilderTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/game/SgfcDateTest.cpp b/test/game/SgfcDateTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/game/SgfcGameResultTest.cpp b/test/game/SgfcGameResultTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/game/SgfcRoundInformationTest.cpp b/test/game/SgfcRoundInformationTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/game/go/SgfcGoMoveTest.cpp b/test/game/go/SgfcGoMoveTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/game/go/SgfcGoPlayerRankTest.cpp b/test/game/go/SgfcGoPlayerRankTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/game/go/SgfcGoPointTest.cpp b/test/game/go/SgfcGoPointTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/game/go/SgfcGoRulesetTest.cpp b/test/game/go/SgfcGoRulesetTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/game/go/SgfcGoStoneTest.cpp b/test/game/go/SgfcGoStoneTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/parsing/SgfcPropertyDecoderTest.cpp b/test/parsing/SgfcPropertyDecoderTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/parsing/SgfcValueConverterTest.cpp b/test/parsing/SgfcValueConverterTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/argument/SgfcArgumentTest.cpp b/test/sgfc/argument/SgfcArgumentTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/argument/SgfcArgumentsTest.cpp b/test/sgfc/argument/SgfcArgumentsTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/backend/SgfcBackendControllerTest.cpp b/test/sgfc/backend/SgfcBackendControllerTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/backend/SgfcBackendDataWrapperTest.cpp b/test/sgfc/backend/SgfcBackendDataWrapperTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/frontend/EncodingTest.cpp b/test/sgfc/frontend/EncodingTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/frontend/SgfcCommandLineTest.cpp b/test/sgfc/frontend/SgfcCommandLineTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/frontend/SgfcDocumentReaderTest.cpp b/test/sgfc/frontend/SgfcDocumentReaderTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/frontend/SgfcDocumentWriterTest.cpp b/test/sgfc/frontend/SgfcDocumentWriterTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/message/SgfcMessageStreamTest.cpp b/test/sgfc/message/SgfcMessageStreamTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/message/SgfcMessageTest.cpp b/test/sgfc/message/SgfcMessageTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/save/SgfcSaveStreamTest.cpp b/test/sgfc/save/SgfcSaveStreamTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/test/sgfc/save/SgfcSgfContentTest.cpp b/test/sgfc/save/SgfcSgfContentTest.cpp
@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------------
-// Copyright 2020 Patrick Näf ([email protected])
+// Copyright 2024 Patrick Näf ([email protected])
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.