Warn and exit when no packages are listed in Aptfile #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
colincasey
force-pushed
the
more_robust_comment_line_check
branch
from
7b97984 to
b24f26b
Compare
colincasey
force-pushed
the
fix_for_aptfile_with_no_packages
branch
from
e8b841d to
e5a642c
Compare
dzuelke
approved these changes
Mar 28, 2024
colincasey
force-pushed
the
more_robust_comment_line_check
branch
from
b24f26b to
c725e16
Compare
colincasey
force-pushed
the
fix_for_aptfile_with_no_packages
branch
from
e5a642c to
2b1891a
Compare
Merged
Frzk
pushed a commit
to Scalingo/apt-buildpack
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error that occurs if an Aptfile with no packages is used, that was introduced by #115. This case is detected now and a warning is printed advising that the buildpack and Aptfile should be removed before exiting the build.
Fixes #117