Skip to content

Commit

Permalink
Merge pull request #425 from stlankes/nemo
Browse files Browse the repository at this point in the history
add comments, improve readability
  • Loading branch information
stlankes authored Feb 20, 2025
2 parents c43fa2a + f6240b9 commit 1f1ed45
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/create.rs
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ pub fn create_container(
};

#[allow(clippy::zombie_processes)]
let _ = std::process::Command::new("/proc/self/exe")
let _child = std::process::Command::new("/proc/self/exe")
.arg("-l")
.arg(child_log_level.as_str())
.arg("--log-format")
Expand Down Expand Up @@ -261,7 +261,7 @@ pub fn create_container(
.write_all(rootfs_path_str.as_bytes())
.expect("Could not write rootfs-path to init pipe!");

//send bundle rootfs path to child
// send bundle rootfs path to child
if is_hermit_container {
let bundle_rootfs_path_str = bundle_rootfs_path_abs
.as_os_str()
Expand Down
1 change: 1 addition & 0 deletions src/init.rs
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,7 @@ fn init_stage_child(args: SetupArgs) -> ! {
if let Some(tap_fd) = tap_fd {
cmd.preserved_fds(vec![tap_fd]);
}
// use implicitly execvp => on success, this function doesn't return
let error = cmd.exec();

//This point should not be reached on successful exec
Expand Down

0 comments on commit 1f1ed45

Please sign in to comment.