Merge pull request pyinstaller#2026 from stephenrauch/close-pe-object

Close PE() object to avoid mmap memory leak
henrykironde · Jun 4, 2016 · 552ac37 · 552ac37
2 parents 192ccc2 + 1f59bd9
commit 552ac37
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/PyInstaller/depend/bindepend.py b/PyInstaller/depend/bindepend.py
@@ -128,6 +128,7 @@ def _getImports_pe(pth):
                 dll, _ = forwarder.split('.')
                 dlls.add(dll + ".dll")
 
+    pe.close()
     return dlls
 
 
@@ -187,10 +188,13 @@ def matchDLLArch(filename):
     if _exe_machine_type is None:
         exe_pe = pefile.PE(sys.executable, fast_load=True)
         _exe_machine_type = exe_pe.FILE_HEADER.Machine
+        exe_pe.close()
 
     pe = pefile.PE(filename, fast_load=True)
 
-    return pe.FILE_HEADER.Machine == _exe_machine_type
+    match_arch = pe.FILE_HEADER.Machine == _exe_machine_type
+    pe.close()
+    return match_arch
 
 def Dependencies(lTOC, xtrapath=None, manifest=None, redirects=None):
     """

diff --git a/PyInstaller/utils/win32/versioninfo.py b/PyInstaller/utils/win32/versioninfo.py
@@ -89,6 +89,7 @@ def pefile_read_version(filename):
     print(dir(pe.VS_FIXEDFILEINFO))
     print(repr(pe.VS_FIXEDFILEINFO))
     print(pe.dump_info())
+    pe.close()
     return vers