Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtf formatter crash on "exotic" fonts #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alessandrobelli
Copy link

There was a crash on this line, in the file State.php:

$font = self::$fonttbl[$this->font];

To trace the problem, we can go into LoadFont and ExtractFontTable in HtmlFormatter.php. Somehow the way rtf is setting the non-common font is not included in this formatter.
To avoid the crash, I changed this:

    if(isset($this->font) {
      $font = self::$fonttbl[$this->font];
      $style .= $font->toStyle();
    }

to


    if(isset($this->font) && count( self::$fonttbl)>0) {
      $font = self::$fonttbl[$this->font];
      $style .= $font->toStyle();
    }

The result is the document without the "exotic" font.

- check if any font was detected to avoid crash. If no font was detected, go on without it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant