Add tests demonstrating V8 Port error handling #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 errors available through
erlang_v8
offer insufficient granularity for graceful recovery of those errors.Fixing that requires reaching beyond the C++ Erlang Port to resolve. However, V8 docs don't easily accommodate cherry-picking one's way through for our purposes here, and acquiring the necessary perspective on V8 internals goes beyond our current time constraints, unfortunately.
Instead for our purposes with router, we can handle those errors by stop/start of V8 VM.
This PR adds tests and code comments demonstrating existing
erlang_v8
behavior.