Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests demonstrating V8 Port error handling #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpezely
Copy link

@dpezely dpezely commented Nov 18, 2021

V8 errors available through erlang_v8 offer insufficient granularity for graceful recovery of those errors.

Fixing that requires reaching beyond the C++ Erlang Port to resolve. However, V8 docs don't easily accommodate cherry-picking one's way through for our purposes here, and acquiring the necessary perspective on V8 internals goes beyond our current time constraints, unfortunately.

Instead for our purposes with router, we can handle those errors by stop/start of V8 VM.

This PR adds tests and code comments demonstrating existing erlang_v8 behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant