Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for row and column span; propagate rendering error information to the output #1097

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Jan 7, 2025

This PR adds support for table cell row and column spanning in the Vuetify template.

It also revises RenderingException so it displays all available messages about rendering errors, still including but no longer limited to the name and location within the .adoc file where the problem occurred.

@tjquinno tjquinno self-assigned this Jan 7, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 7, 2025
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romain-grecourt romain-grecourt merged commit fe506cb into helidon-io:master Jan 8, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants