To merge #1
Open
To merge #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Add some of the changes made to CHANGELOG.md
This assumes that there is a primary playTask now
Fix several issues with launching Windows games
Thanks for contributing!
This should replace setup-tools in the future.
This links are made to be used only once. The second time you do not get a response. This was causing #484 it seems. This took a while to figure out, but it should be fixed with this.
Fix extract_by_wine when PC has optical drive
* All installations now try to use a fixed folder 'c:\game' within the wineprefix as install target. * Wine installer tries unattended mode first and falls back to wizard dialog on failure The fallback will break if user changes the target directory in the wizard, but it's better then not working at all and the directory requirement can be documented. * Adjust launcher.py to use wine-internal paths whereever possible
use env for wine when launching
* Fix _exe_cmd in installer.py * Only print if print_output is on * Set stdout and stderr to non-blocking in exe_cmd function
Rework installation of windows games
critical bug fix in installer
Desktop file creation
reworked and enhanced lang_install: 1. now uses 2 different strategies for language detection 2. renamed to match_game_lang_to_installer to better match actual purpose 3. slightly change _exe_cmd again to make it consume everything of Popen without readlines() calls after actual execution loop
* sleep before poll in _exe_cmd * change how mocks in tests for match_lang_to_installer are set up
Wine: Installer language
Fix Unreal Gold being unable to launch
adjust title of third-party login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As automatic upstream merge is not possible.