STORM-3424: storm-submit-tools: fix all checkstyle warnings

hecsalazar · Jun 26, 2019 · 443d99a · 443d99a
1 parent fb76dd1
commit 443d99a
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 11 deletions.
diff --git a/storm-submit-tools/pom.xml b/storm-submit-tools/pom.xml
@@ -115,7 +115,7 @@
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <!--Note - the version would be inherited-->
                 <configuration>
-                    <maxAllowedViolations>38</maxAllowedViolations>
+                    <maxAllowedViolations>0</maxAllowedViolations>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/storm-submit-tools/src/main/java/org/apache/storm/submit/command/DependencyResolverMain.java b/storm-submit-tools/src/main/java/org/apache/storm/submit/command/DependencyResolverMain.java
@@ -223,12 +223,30 @@ private static String getLocalMavenRepositoryPath() {
 
     private static Options buildOptions() {
         Options options = new Options();
-        options.addOption(null, OPTION_ARTIFACTS_LONG, true, "REQUIRED string representation of artifacts");
-        options.addOption(null, OPTION_ARTIFACT_REPOSITORIES_LONG, true, "OPTIONAL string representation of artifact repositories");
-        options.addOption(null, OPTION_MAVEN_LOCAL_REPOSITORY_DIRECTORY_LONG, true, "OPTIONAL string representation of local maven repository directory path");
-        options.addOption(null, OPTION_PROXY_URL_LONG, true, "OPTIONAL URL representation of proxy server");
-        options.addOption(null, OPTION_PROXY_USERNAME_LONG, true, "OPTIONAL Username of proxy server (basic auth)");
-        options.addOption(null, OPTION_PROXY_PASSWORD_LONG, true, "OPTIONAL Password of proxy server (basic auth)");
+        options.addOption(null,
+                OPTION_ARTIFACTS_LONG,
+                true,
+                "REQUIRED string representation of artifacts");
+        options.addOption(null,
+                OPTION_ARTIFACT_REPOSITORIES_LONG,
+                true,
+                "OPTIONAL string representation of artifact repositories");
+        options.addOption(null,
+                OPTION_MAVEN_LOCAL_REPOSITORY_DIRECTORY_LONG,
+                true,
+                "OPTIONAL string representation of local maven repository directory path");
+        options.addOption(null,
+                OPTION_PROXY_URL_LONG,
+                true,
+                "OPTIONAL URL representation of proxy server");
+        options.addOption(null,
+                OPTION_PROXY_USERNAME_LONG,
+                true,
+                "OPTIONAL Username of proxy server (basic auth)");
+        options.addOption(null,
+                OPTION_PROXY_PASSWORD_LONG,
+                true,
+                "OPTIONAL Password of proxy server (basic auth)");
         return options;
     }
 }
diff --git a/storm-submit-tools/src/main/java/org/apache/storm/submit/dependency/Booter.java b/storm-submit-tools/src/main/java/org/apache/storm/submit/dependency/Booter.java
@@ -18,15 +18,15 @@
 
 package org.apache.storm.submit.dependency;
 
+import java.io.File;
+
 import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
 import org.eclipse.aether.DefaultRepositorySystemSession;
 import org.eclipse.aether.RepositorySystem;
 import org.eclipse.aether.RepositorySystemSession;
 import org.eclipse.aether.repository.LocalRepository;
 import org.eclipse.aether.repository.RemoteRepository;
 
-import java.io.File;
-
 /**
  * Manage mvn repository.
  */

diff --git a/...ubmit-tools/src/main/java/org/apache/storm/submit/dependency/RepositorySystemFactory.java b/...ubmit-tools/src/main/java/org/apache/storm/submit/dependency/RepositorySystemFactory.java
@@ -18,6 +18,8 @@
 
 package org.apache.storm.submit.dependency;
 
+import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
+
 import org.eclipse.aether.RepositorySystem;
 import org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory;
 import org.eclipse.aether.impl.DefaultServiceLocator;
@@ -26,8 +28,6 @@
 import org.eclipse.aether.transport.file.FileTransporterFactory;
 import org.eclipse.aether.transport.http.HttpTransporterFactory;
 
-import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
-
 /**
  * Get maven repository instance.
  */