Add unimplemented functions from array_api #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermeleobas
added
enhancement
tupui
reviewed
Mar 15, 2022
guilhermeleobas
force-pushed
the
guilhermeleobas/missing_array_api_funcs
branch
from
48abb56 to
99068f2
Compare
guilhermeleobas
force-pushed
the
guilhermeleobas/missing_array_api_funcs
branch
from
99068f2 to
3cd9c85
Compare
pearu
suggested changes
Mar 17, 2022
There was a problem hiding this comment.
I have only a few comments, otherwise looks good.
While implementing and documenting Array API in the HeavyDB context, I think we should clearly distinguish the "Not implemented" and "Not supported" cases. The "not implemented" means that the corresponding feature can be implemented if taken some time for it, while "not supported" means that the corresponding feature does not makes sense because the underlying datastructures do not support it. For instance, OmnisciDB currently is able to support only 1-D arrays, and hence, we should not give hope to users that inherently N-D operations such as matrix operations can be supported via raising an rbc issue.
pearu
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't implement all the functions, only include the files so that they can show up in the docs.