Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CET time to UTC #379

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Change CET time to UTC #379

merged 2 commits into from
Feb 22, 2024

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Feb 20, 2024 •
edited
Loading

See #372..

dr0i added 2 commits February 20, 2024 15:08
@dr0i
Change times from CET to UTC (#372)
f8b652a 
OAI-PMH expects UTC times.We use CET timed server and so these times
must be chenged to UTC. When files are produced these will have CET
based timestamps, though.
@dr0i
Fix "retry" part
ca51975 
The "retry" part is hard coded to "not working" and these code changes make this
clearer.

- remove unused import
@dr0i dr0i requested a review from fsteeg February 20, 2024 14:11
@fsteeg
Copy link
Member

fsteeg commented Feb 20, 2024

But with that setup we'd have to change the code twice a year (for winter and summer time). Shouldn't we instead pass the actual UTC date (TZ=UTC date +%Y-%m-%dT%H:%M:%SZ)?

@fsteeg fsteeg assigned dr0i and unassigned fsteeg Feb 20, 2024
@dr0i
Copy link
Member Author

dr0i commented Feb 20, 2024

I am confident that the java library is , analog to date, capable of calculating the proper UTC from a given CET (https://github.com/hbz/lobid-gnd/pull/379/files#diff-bfe0c0b1d86bf1b98980191cde0ceb4007a772998cbeca1beb37af785c9848e0R167). What makes you unsure about it?

@dr0i dr0i assigned fsteeg and unassigned dr0i Feb 20, 2024
fsteeg
fsteeg approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, you're right. Since summer time is called CEST, I assumed CET is always UTC+1, but it's actually UTC+1 or UTC+2, depending on the date.

@fsteeg fsteeg assigned dr0i and unassigned fsteeg Feb 20, 2024
@dr0i dr0i merged commit b8afced into master Feb 22, 2024
1 check passed
@dr0i dr0i deleted the 372-changeCetTimeToUtc branch February 22, 2024 08:29
@dr0i
Copy link
Member Author

dr0i commented Feb 22, 2024

Deployed. Closed.

@dr0i dr0i mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsteeg fsteeg fsteeg approved these changes

Assignees

@dr0i dr0i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr0i @fsteeg