Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Twitter; use Mastodon #365

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Remove Twitter; use Mastodon #365

merged 1 commit into from
Nov 16, 2023

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Nov 13, 2023

See #364.

  • update fontawesome to 6.4.2 (gains mastodon) by copy new css to old css
  • refactor "fa" (fontawesome) to "fa-brands" for brands (github and twitter)

@dr0i
Copy link
Member Author

dr0i commented Nov 13, 2023

Deployed to stage, see http://stage.lobid.org/gnd @acka47 for functional review.

@dr0i dr0i requested a review from acka47 November 13, 2023 16:09
@dr0i
Copy link
Member Author

dr0i commented Nov 14, 2023

Wait , this is not ready - the Blog (pencil) icon is missing.

- update fontawesome to 6.4.2 (gains mastodon) by copy new css to old css
- add webfonts
- remove old awesome fonts
- refactor "fa" (fontawesome) to "fa-brands" for brands (github and twitter)
@dr0i dr0i force-pushed the 364-switchFromTitterToMastodon branch from ab7aad2 to 0c51d7d Compare November 14, 2023 09:13
@dr0i
Copy link
Member Author

dr0i commented Nov 14, 2023

Fixed the pencil. Now ready for review @acka47 http://stage.lobid.org/gnd.

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dr0i dr0i requested a review from sroertgen November 14, 2023 09:47
@dr0i
Copy link
Member Author

dr0i commented Nov 14, 2023

Assigning @sroertgen for code review.

@dr0i dr0i assigned sroertgen and unassigned acka47 Nov 14, 2023
@dr0i dr0i merged commit e64ab90 into master Nov 16, 2023
1 check passed
@dr0i dr0i deleted the 364-switchFromTitterToMastodon branch November 16, 2023 13:02
@dr0i
Copy link
Member Author

dr0i commented Nov 16, 2023

Deployed to https://lobid.org/gnd - closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants