Restored Deencapsulation and its related classes. #157
Conversation
|
Thanks @yukkes , will look to merge probably tomorrow and try to get a release out shortly after. |
|
Thank you for your response. |
….getDeclaredField() class from private to public.
| import static mockit.internal.reflection.ParameterReflection.hasMoreSpecificTypes; | ||
| import static mockit.internal.reflection.ParameterReflection.indexOfFirstRealParameter; | ||
| import static mockit.internal.reflection.ParameterReflection.matchesParameterTypes; | ||
| import static mockit.internal.reflection.ParameterReflection.*; |
There was a problem hiding this comment.
@yukkes Please don't use star imports. Usually your IDE causes that, make sure intellij (going on a limb that is what you are using) is setup appropriately to stop doing that. Its meant for use if something like 99 imports which isn't the case.
|
@yukkes I moved jmockit up to require jdk 11, do you foresee that causing any issues for you with this? Do note jdk 21 will fail as that is an issue still so generally just need rest to build ok. An alternative to this we probably should document is that Powermock-reflect Whitebox does the same. In fact, for any usage I had at work and some 2k repos I help support we long already dumped that class. I however understand not everyone else had 2 to 3 years of understanding this fork was alive and well to overcome the issues or know of the alternative. So that said, as soon as this is good to go, I can get a release out right away. |
|
ok just fix the star import issue, rest I think is great. I can merge this then and release right after. If you need it to work with java 8 will need to know that as I will have to backport it. If its fine at java 11, great makes my life easier :) |
|
Actually I'm a bit impatient tonight. I'm going to merge, I'll fix my trivial concern and release this bit! |
The Deencapsulation class has been restored.
Added DeencapsulationTest class and have verified that all tests PASS.