-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-arch builds for hawtio-online-example images #47
Conversation
4f658c1
to
e504d9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dale-fu Thanks for your contribution! However, there are many unrelated commits, which make it hard to review. I'd expect only 1-2 commits in the pull req. Could you please try rebasing to the latest main again cleanly only with the commits you're really making? Thank you.
.github/workflows/build.yml
Outdated
docker buildx build -t quay.io/hawtio/jkube-java-${{ matrix.java }}:latest \ | ||
--platform linux/amd64,linux/arm64,linux/ppc64le,linux/s390x \ | ||
--provenance=false \ | ||
--push target/image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be pushed to quay right? Still not very happy with having to build our own images for building - it should be provided for SB when it's officially supported.
I have switched this request to merge into the |
72a4f6d
to
54cdf14
Compare
I have updated the PR by replacing the default |
@dale-fu Looks great now. Unfortunately, it's diverging from main again. Could you rebase it with main and resolve conflicts? |
54cdf14
to
3adb8d6
Compare
Rebased and resolved the conflicts, but I will still need assistance with testing the modified springboot image going forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great to me.
What should we assist you on this? @mmuzikar @phantomjinx You might want to review this (again) before merging. |
@tadayosi I think the major difference between the |
If I'm not mistaken, I think @phantomjinx also developed a Spring Boot example for OpenShift. @phantomjinx Do you have an OpenShift example? |
I have submitted a camel-quarkus example that uses maven and the quarkus OpenShift deployment extension - here. I also have created a camel-helloworld example for Springboot, which is directed towards submitting to OpenShift. Do they help? |
I think I'm mostly focusing on multi-arching the |
I have made changed to the SpringBoot image to use the Red Hat OpenJDK base images that is multi-arch and added the jolokia agent into the container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me now. Let's merge it.
Adding multi-arch images for arm64, ppc64le and s390x.