Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-testid to the elements missing it on Preference pages #1304

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Add data-testid to the elements missing it on Preference pages #1304

merged 1 commit into from
Jan 21, 2025

Conversation

jsolovjo
Copy link
Contributor

In this PR:

  • Add data-testid attributes to the elements that were missing it on Preference pages;
  • It will simplify the testing;

@jsolovjo jsolovjo requested review from tadayosi and mmuzikar January 20, 2025 14:13
@jsolovjo jsolovjo changed the title Add data-testid to the elements missing it on Preferece pages Add data-testid to the elements missing it on Preference pages Jan 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Test Results

  8 files  ±0    8 suites  ±0   1h 3m 54s ⏱️ +47s
 67 tests ±0   65 ✅ ±0   2 💤 ±0  0 ❌ ±0 
544 runs  ±0  516 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 293308e. ± Comparison against base commit 28569cd.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Jan 20, 2025 •
edited
Loading

Test results

Run attempt: 3123
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 68 65 3 0 0 474.945
test-results-quarkus-node(18)-java(21)-firefox 68 65 3 0 0 474.747
test-results-quarkus-node(20)-java(17)-firefox 68 65 3 0 0 477.155
test-results-quarkus-node(20)-java(21)-firefox 68 65 3 0 0 481.279
test-results-springboot-node(18)-java(17)-firefox 68 64 4 0 0 478.597
test-results-springboot-node(18)-java(21)-firefox 68 64 4 0 0 476.729
test-results-springboot-node(20)-java(17)-firefox 68 64 4 0 0 489.309
test-results-springboot-node(20)-java(21)-firefox 68 64 4 0 0 481.53

@jsolovjo jsolovjo force-pushed the add-testids-preference-page branch from d636b7e to 3fc301e Compare January 20, 2025 14:22
@jsolovjo jsolovjo force-pushed the add-testids-preference-page branch from f6b5224 to 293308e Compare January 20, 2025 15:05
@jsolovjo jsolovjo requested a review from mmuzikar January 20, 2025 15:25
@mmuzikar mmuzikar merged commit 89cd63f into hawtio:main Jan 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmuzikar mmuzikar mmuzikar approved these changes

@tadayosi tadayosi tadayosi approved these changes

Assignees

@tadayosi tadayosi

Labels
area/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsolovjo @tadayosi @mmuzikar