Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a duplicate span. #7

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

SamirTalwar
Copy link
Contributor

We were adding the request span twice.

This also factors the authentication layer into its own function, because I think if the routing construction was smaller, this would have been easier to catch earlier.

@SamirTalwar SamirTalwar requested a review from a team April 23, 2024 15:01
@SamirTalwar SamirTalwar added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit a273a01 Apr 23, 2024
8 checks passed
@SamirTalwar SamirTalwar deleted the samirtalwar/remove-duplicate-span branch April 23, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants