Throttle health checks to 1 request per second. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple requests made during the throttle period will be batched together.
SamirTalwar
requested review from
paf31,
daniel-chambers,
soupi,
BenoitRanque and
a team
paf31
reviewed
Aug 7, 2024
There was a problem hiding this comment.
I think we need to be careful about adding so much functionality to SDKs. We could specify it and move it into a throttling library (or pick another), or let the developer opt into throttling with a function call, but anything in one SDK should arguably be in all SDKs so I don't think we should solve it just once here.
|
@paf31, how would you feel about keeping it in this library, but making it opt-in by instructing the connector developer to make their own |
|
Gonna close this; we'll find another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple requests made during the throttle period will be batched together.
This uses a home-grown throttle; it probably deserves some scrutiny. I have tried to add a lot of commentary on its internals.