Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge multiscreen webview fix into latest main - Support for multiscreen configuration for WebView display #246

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

denisabt
Copy link

@denisabt denisabt commented Feb 17, 2025

Note(Amadeo): related to #152

@denisabt denisabt marked this pull request as ready for review February 18, 2025 19:46
@denisabt
Copy link
Author

This fixes Bug 152, and is based on the latest main. It also contains text resources. There are some layout improvements I plan to fix, but I try to avoid a running away code base, thus early checkin/merge.

@denisabt denisabt changed the title Merge multiscreen webview fix into latest main Merge multiscreen webview fix into latest main - Support for multiscreen configuration for WebView display Feb 18, 2025
@amadeo-alex
Copy link
Collaborator

nice one, targeting current main should make it quite easy to target 2.2.0-beta1 (that this will end up in :D) - you can even change the target from main to https://github.com/hass-agent/HASS.Agent/tree/development-2.2.0-beta1
give me a day or two to review pls :)

@amadeo-alex amadeo-alex added this to the 2.2.0 milestone Feb 18, 2025
@denisabt
Copy link
Author

While testing, I found on one specific dual-screen setup a layout issue, the WebView would not show at bottom right on the second screen. Will look into that to fix it soon too.

@denisabt
Copy link
Author

@amadeo-alex - i just added a fix for multi-screen form bottom right positioning. Seems to make sense and is tested. PR ready for review I would say :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants