-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-4069, H-4081, H-4110: Data type conversions in data type editor; entity editor fixes #6598
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6598 +/- ##
==========================================
- Coverage 20.93% 20.85% -0.08%
==========================================
Files 583 558 -25
Lines 20111 19418 -693
Branches 3002 2954 -48
==========================================
- Hits 4210 4050 -160
+ Misses 15844 15311 -533
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
if (token === "self") { | ||
value = sourceTitle; | ||
} else if (typeof token === "string") { | ||
value = operatorToOpCharacterMap[token]; | ||
} else if (Array.isArray(token)) { | ||
throw new Error("Nested conversion expressions are not supported"); | ||
} else { | ||
value = formatNumber(token.const); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue in your code:
String comparisons using '===', '!==', '!=' and '==' is vulnerable to timing attacks. A timing attack allows the attacker to learn potentially sensitive information by, for example, measuring how long it takes for the application to respond to a request. More info: https://nodejs.org/en/learn/getting-started/security-best-practices#information-exposure-through-timing-attacks-cwe-208
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>
for false positive/ar <comment>
for acceptable risk/other <comment>
for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by node_timing_attack.
You can view more details about this finding in the Semgrep AppSec Platform.
🌟 What is the purpose of this PR?
This PR adds the MVP for data type conversion display and editing in the data type editor.
In the entity editor it also:
To keep simple things simple the following restrictions are in place for now:
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
H-4161: Still some slightly-off / floating point issues in the FE when values undergo multiple conversion steps
🛡 What tests cover this?
❓ How to test this?
📹 Demo
Adding a data type under a parent which already has a canonical in the group
frequency.mp4
Selecting an arbitrary conversion target from a data type not in a group
length.mp4