-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-3699, H-3374: Use and set value dataTypeId
in the entity editor
#5813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5813 +/- ##
==========================================
- Coverage 23.07% 23.00% -0.08%
==========================================
Files 568 568
Lines 19103 19165 +62
Branches 2697 2715 +18
==========================================
Hits 4408 4408
- Misses 14643 14705 +62
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vilkinsons
previously approved these changes
Dec 5, 2024
252618a
to
00bd165
Compare
vilkinsons
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/apps > hash*
Affects HASH (a `hash-*` app)
area/apps > hash-api
Affects the HASH API (app)
area/apps
area/libs
Relates to first-party libraries/crates/packages (area)
area/tests
New or updated tests
type/eng > backend
Owned by the @backend team
type/eng > frontend
Owned by the @frontend team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
We've updated entities' metadata to track the
dataTypeId
of each leaf value in their properties, to be able to distinguish between data types which have the same primitive value but different semantic meaning (or other constraints).This PR updates the entity editor to actually use the
dataTypeId
to know what data type a value is of, rather than guessing it solely from the value, which is now impossible.As a drive-by it removes reference to the
EmptyList
type which we are not using.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
This PR has some partial code to do with validating entities which will be completed as part of H-3697 once unblocked by Graph API work.
H-3373: the editor doesn't yet support new custom data types, e.g. enums, tuples, array data.
🐾 Next steps
abstract
data types which can't be instantiated (i.e. don't allow selecting them as the type for a value)🛡 What tests cover this?
❓ How to test this?