build github action to verify changelog entries have been added #36344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
added
the
no-changelog-needed
DanielMSchmidt
force-pushed
the
changelog-github-action
branch
from
b13532f to
52b5a35
Compare
liamcervante
approved these changes
Jan 17, 2025
| repo, | ||
| })).data; | ||
|
|
||
| const existingComment = allComments.find(c => c.body.startsWith(commentStart)); |
There was a problem hiding this comment.
if you wanted to be double sure, the response should also contain the user who made the comment. You could check that is the same user we're executing as now. We can always come back and add this if we find people do start writing comments that start with ## Changelog Warning
There was a problem hiding this comment.
Yeah, let's fix this if the need arises 👍 We will probably need to touch this script at some point again when new needs surface :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR warns the user if they a) miss a changelog entry, b) miscategorize a changelog entry, c) the changelog has been manually edited outside a release.
It creates / updates / deletes a comment on the PR.
Fixes #
Target Release
1.11.x
CHANGELOG entry