relax import for_each validation #36119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import blocks with for_each were intended to require resource blocks with a matching expansion. This validation however did not take place in prior releases, and configurations with this mismatch currently exist in production. That simple validation also does not take into account a single resource instance inside of an expanded module, which is a valid use case and harder to check for at the point of validation. That will still fail correctly during plan if the targets are not available. We can skip this validation for now, and work on generating static validation errors later on if possible, taking into account the expanded module case.
jbardin
added
the
1.10-backport
liamcervante
approved these changes
Nov 28, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import blocks with for_each were intended to require resource blocks with a matching expansion. This validation however did not take place in prior releases, and configurations with this mismatch currently exist in production.
That simple validation also does not take into account a single resource instance inside of an expanded module, which is a valid use case and harder to check for at the point of validation. That will still fail correctly during plan if the targets are not available.
We can skip this validation for now, and work on generating static validation errors later on if possible, taking into account the expanded module case.
Fixes #36111