Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/views: Fix flaky hook tests #36104

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

radeksimko
Copy link
Member

This aims to eliminate the failures of a handful of tests I've seen failing lately just because time.Sleep takes longer to "wake up" than the declared minimum time period.

As per official docs:

Sleep pauses the current goroutine for at least the duration d.

Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach! Hopefully it works as expected 😬

@radeksimko radeksimko merged commit bfa011e into main Dec 9, 2024
11 checks passed
@radeksimko radeksimko deleted the t-fix-flaky-hooks-tests branch December 9, 2024 10:23
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants