Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify single-removal behavior in trimsuffix and trimprefix docs #35900

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

rfalke
Copy link
Contributor

@rfalke rfalke commented Oct 24, 2024

The doc was not so clear if the suffix was removed multiple times. There is a difference in behavior to trim. The documentation is clarified with this MR.

Target Release

1.10.x

Draft CHANGELOG entry

Doc Update

  • Clarify single-removal behavior in trimsuffix and trimprefix docs

Copy link

hashicorp-cla-app bot commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@crw crw added the 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 18, 2024
@crw crw requested review from a team as code owners November 18, 2024 23:34
@crw crw merged commit fcac006 into hashicorp:main Nov 18, 2024
6 of 8 checks passed
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants