-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_maps_account
- Update documentation for location to be (Required) #28652
#28675
azurerm_maps_account
- Update documentation for location to be (Required) #28652
#28675
Conversation
azurerm_maps_account
added default to global for location for issue #28652azurerm_maps_account
- added default to location as global for issue #28652
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mikemadeja, location
becoming Required
in the schema was a breaking change that was made in 4.0 but it looks like we missed updating the documentation to reflect this when it was released. Could you please revert these changes and update the documentation instead?
@stephybun - I have reverted and updated the documentation. |
@@ -50,7 +50,7 @@ The following arguments are supported: | |||
|
|||
* `local_authentication_enabled` - (Optional) Is local authentication enabled for this Azure Maps Account? When `false`, all authentication to the Azure Maps data-plane REST API is disabled, except Azure AD authentication. Defaults to `true`. | |||
|
|||
* `location` - (Optional) The Location in which the Azure Maps Account should be provisioned. Changing this forces a new resource to be created. Defaults to `global`. | |||
* `location` - (Required) The Location in which the Azure Maps Account should be provisioned. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I ask you to scoot the position of this up so that it is listed between resource_group_name
and sku_name
? Required
properties are grouped together by convention in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been moved.
azurerm_maps_account
- added default to location as global for issue #28652azurerm_maps_account
- Update documentation for location to be (Required) #28652
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @mikemadeja LGTM 💯
Community Note
Description
For this issue, I have added a default to global for location - #28652
I have removed the location on a test so it validates working with
global
default location.PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_maps_account
- Defaultlocation
toglobal
if nothing is passed tolocation
parameter.This is a (please select all that apply):
Related Issue(s)
Fixes #28652
Note
If this PR changes meaningfully during the course of review please update the title and description as required.