Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_private_dns_zone_virtual_network_link - Update privatedns API to 2024-06-01 #28599

Merged
merged 1 commit into from
Jan 27, 2025
Merged

azurerm_private_dns_zone_virtual_network_link - Update privatedns API to 2024-06-01 #28599

merged 1 commit into from
Jan 27, 2025
+97 −55

Conversation

EppO
Copy link
Contributor

@EppO EppO commented Jan 24, 2025 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is the first step towards addressing #28087, upgrading privatedns API to 2024-06-01 that exposes a new setting ResolutionPolicy (Supported values are Default or NxDomainRedirect)

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

N/A

Testing

N/A, no code change besides API versions.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_private_dns_zone_virtual_network_link - Use privatedns API 2024-06-01

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28087

@EppO EppO requested a review from a team as a code owner January 24, 2025 22:54
@EppO EppO changed the title Update privatedns API to 2024-06-01 azurerm_private_dns_zone_virtual_network_link - Update privatedns API to 2024-06-01 Jan 24, 2025
stephybun
stephybun approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, thanks @EppO LGTM 👍

@stephybun stephybun merged commit 49158d5 into hashicorp:main Jan 27, 2025
38 checks passed
@github-actions github-actions bot added this to the v4.17.0 milestone Jan 27, 2025
stephybun added a commit that referenced this pull request Jan 27, 2025
@stephybun
Update for #28592 #28583 #28599 #28590 #28453
8d1f9bf
@EppO EppO deleted the update-vnetlinks-sdk branch January 27, 2025 15:48
@EppO EppO mentioned this pull request Jan 27, 2025
Closed
1 task
jackofallops added a commit that referenced this pull request Jan 31, 2025
@stephybun @catriona-m
@jackofallops @sreallymatt @mbfrahry
CHANGELOG.md for 4.17.0 (#28561)
3c5cace 
* Update for #27950

* Update for #27824

* Update for #28592 #28583 #28599 #28590 #28453

* Update #28528

* Update for #27853

* Update CHANGELOG.md #28221

* Update for #27760

* Update CHANGELOG.md #28480

* Update CHANGELOG.md typo

* Update CHANGELOG.md #28372

* Update CHANGELOG.md for #26047

also alphabetised ENHANCEMENTS

* Update for #28146

* Update CHANGELOG.md #28013

* Update CHANGELOG.md for #28492

* Update CHANGELOG.md for #28648

* Update CHANGELOG.md for #28549

* Update for #28469 #28620

* prep for release

* i touched it last

---------

Co-authored-by: catriona-m <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
dependencies service/dns service/mysql service/network service/postgresql size/L
Projects
None yet
Milestone
v4.17.0
Development

Successfully merging this pull request may close these issues.

Support for resolutionPolicy on azurerm_private_dns_zone_virtual_network_link
2 participants
@EppO @stephybun