azurerm_logic_app_action_http - omit queries when not specified

[ziyeqf]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

empty map and nil have different definitions on the service side, omit it when it's not specified on configuration.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

❯ tftest logic TestAccLogicAppActionHttp_
=== RUN   TestAccLogicAppActionHttp_basic
=== PAUSE TestAccLogicAppActionHttp_basic
=== RUN   TestAccLogicAppActionHttp_complete
=== PAUSE TestAccLogicAppActionHttp_complete
=== RUN   TestAccLogicAppActionHttp_requiresImport
=== PAUSE TestAccLogicAppActionHttp_requiresImport
=== RUN   TestAccLogicAppActionHttp_headers
=== PAUSE TestAccLogicAppActionHttp_headers
=== RUN   TestAccLogicAppActionHttp_queries
=== PAUSE TestAccLogicAppActionHttp_queries
=== RUN   TestAccLogicAppActionHttp_dynamicFunction
=== PAUSE TestAccLogicAppActionHttp_dynamicFunction
=== RUN   TestAccLogicAppActionHttp_bodyDiff
=== PAUSE TestAccLogicAppActionHttp_bodyDiff
=== RUN   TestAccLogicAppActionHttp_disappears
=== PAUSE TestAccLogicAppActionHttp_disappears
=== RUN   TestAccLogicAppActionHttp_runAfter
=== PAUSE TestAccLogicAppActionHttp_runAfter
=== CONT  TestAccLogicAppActionHttp_basic
=== CONT  TestAccLogicAppActionHttp_dynamicFunction
=== CONT  TestAccLogicAppActionHttp_headers
=== CONT  TestAccLogicAppActionHttp_disappears
=== CONT  TestAccLogicAppActionHttp_queries
=== CONT  TestAccLogicAppActionHttp_bodyDiff
=== CONT  TestAccLogicAppActionHttp_runAfter
=== CONT  TestAccLogicAppActionHttp_complete
--- PASS: TestAccLogicAppActionHttp_headers (113.97s)
=== CONT  TestAccLogicAppActionHttp_requiresImport
--- PASS: TestAccLogicAppActionHttp_queries (114.24s)
--- PASS: TestAccLogicAppActionHttp_disappears (116.67s)
--- PASS: TestAccLogicAppActionHttp_basic (132.71s)
--- PASS: TestAccLogicAppActionHttp_dynamicFunction (149.04s)
--- PASS: TestAccLogicAppActionHttp_complete (159.73s)
--- PASS: TestAccLogicAppActionHttp_requiresImport (74.80s)
--- PASS: TestAccLogicAppActionHttp_bodyDiff (216.38s)
--- PASS: TestAccLogicAppActionHttp_runAfter (222.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 222.463s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_logic_app_action_http - omit queries when not specified [azurerm_logic_app_action_http - omit queries when not specified #28447]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #28429

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

@ziyeqf could you extend the following test case to add a second step where queries is removed and validate that this works for that case?

terraform-provider-azurerm/internal/services/logic/logic_app_action_http_resource_test.go

Lines 82 to 95 in f6886d7

	func TestAccLogicAppActionHttp_queries(t *testing.T) {
	data := acceptance.BuildTestData(t, "azurerm_logic_app_action_http", "test")
	r := LogicAppActionHttpResource{}
	data.ResourceTest(t, r, []acceptance.TestStep{
	{
	Config: r.queries(data),
	Check: acceptance.ComposeTestCheckFunc(
	check.That(data.ResourceName).ExistsInAzure(r),
	),
	},
	data.ImportStep(),
	})
	}

[ziyeqf]

Here is the result of extended test case

❯ tftest logic TestAccLogicAppActionHttp_queries
=== RUN   TestAccLogicAppActionHttp_queries
=== PAUSE TestAccLogicAppActionHttp_queries
=== CONT  TestAccLogicAppActionHttp_queries
--- PASS: TestAccLogicAppActionHttp_queries (242.09s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 242.172s

[stephybun]

Thanks @ziyeqf LGTM 👍