Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix azurerm_storage_container import command #28419

Conversation

ewencodes
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

When importing a storage container into the tf state, we have to use the management id and not the url so this PR fixes the tf documentation.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Related Issue(s)

Fixes #28409

@@ -82,8 +82,8 @@ The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/l

## Import

Storage Containers can be imported using the `resource id`, e.g.
Storage Containers can be imported using the `resource management id`, e.g.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Storage Containers can be imported using the `resource management id`, e.g.
Storage Containers can be imported using the `resource manager id`, e.g.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @stephybun :)

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ewencodes LGTM 👍

@stephybun stephybun merged commit 76e8d80 into hashicorp:main Jan 10, 2025
7 checks passed
@github-actions github-actions bot added this to the v4.16.0 milestone Jan 10, 2025
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
* docs: fix storage container import command

* chore: wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage_account_id empty when importing azurerm_storage_container into the state
3 participants