-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream_analytics_output_cosmosdb
: add support for authentication_mode
#28372
stream_analytics_output_cosmosdb
: add support for authentication_mode
#28372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @jiaweitao001 - I left one comment inline but once that is addressed I can take another look. Thanks!
@@ -215,6 +228,8 @@ func (r OutputCosmosDBResource) Read() sdk.ResourceFunc { | |||
} | |||
state.PartitionKey = partitionKey | |||
|
|||
state.AuthenticationMode = string(*output.Properties.AuthenticationMode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
state.AuthenticationMode = string(*output.Properties.AuthenticationMode) | |
state.AuthenticationMode = string(pointer.From(output.Properties.AuthenticationMode)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jiaweitao001 LGTM!
* Update for #27950 * Update for #27824 * Update for #28592 #28583 #28599 #28590 #28453 * Update #28528 * Update for #27853 * Update CHANGELOG.md #28221 * Update for #27760 * Update CHANGELOG.md #28480 * Update CHANGELOG.md typo * Update CHANGELOG.md #28372 * Update CHANGELOG.md for #26047 also alphabetised ENHANCEMENTS * Update for #28146 * Update CHANGELOG.md #28013 * Update CHANGELOG.md for #28492 * Update CHANGELOG.md for #28648 * Update CHANGELOG.md for #28549 * Update for #28469 #28620 * prep for release * i touched it last --------- Co-authored-by: catriona-m <[email protected]> Co-authored-by: jackofallops <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>
Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
stream_analytics_output_cosmosdb
: add support forauthentication_mode
[https://github.com/Creating authentication_mode parameter for azurerm_stream_analytics_output_cosmosdb #18362]This is a (please select all that apply):
Related Issue(s)
Fixes #18362
Note
If this PR changes meaningfully during the course of review please update the title and description as required.