azurerm_kubernetes_fleet_manager - Add support for hub_profile property
#28365
+196
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-henglu
suggested changes
Dec 23, 2024
| }) | ||
| } | ||
|
|
||
| func TestAccKubernetesFleetManager_update(t *testing.T) { |
There was a problem hiding this comment.
Please keep this test case to verify if the tags can be updated. You can create a update function to provide the config with updated tags.
There was a problem hiding this comment.
Added
stephybun
requested changes
Jan 13, 2025
Comment on lines
+110
to
116
| var model KubernetesFleetManagerModel | ||
| if err := metadata.Decode(&model); err != nil { | ||
| return fmt.Errorf("decoding: %+v", err) | ||
| } | ||
|
|
||
| client := metadata.Client.ContainerService.V20231015.Fleets | ||
| subscriptionId := metadata.Client.Account.SubscriptionId |
There was a problem hiding this comment.
Please be mindful of the ordering of calls here, boilerplate code should follow the same pattern and ordering as the rest of the provider.
Suggested change
| var model KubernetesFleetManagerModel | |
| if err := metadata.Decode(&model); err != nil { | |
| return fmt.Errorf("decoding: %+v", err) | |
| } | |
| client := metadata.Client.ContainerService.V20231015.Fleets | |
| subscriptionId := metadata.Client.Account.SubscriptionId | |
| client := metadata.Client.ContainerService.V20231015.Fleets | |
| subscriptionId := metadata.Client.Account.SubscriptionId | |
| var model KubernetesFleetManagerModel | |
| if err := metadata.Decode(&model); err != nil { | |
| return fmt.Errorf("decoding: %+v", err) | |
| } |
| if !response.WasNotFound(existing.HttpResponse) { | ||
| return metadata.ResourceRequiresImport(r.ResourceType(), id) | ||
| } | ||
|
|
||
| var payload fleets.Fleet | ||
| r.mapKubernetesFleetManagerResourceSchemaToFleet(config, &payload) | ||
| fleetResource := &fleets.Fleet{ |
There was a problem hiding this comment.
This is usually called params or payload
| output.Tags = tags.Flatten(input.Tags) | ||
| func flattenFleetHubProfileModel(input *fleets.FleetHubProfile) []FleetHubProfileModel { | ||
| if input == nil { | ||
| return nil |
There was a problem hiding this comment.
We should return an empty hub profile model here
Suggested change
| return nil | |
| return []FleetHubProfileModel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
azurerm_kubernetes_fleet_manager- Add support forhub_profilepropertyThe current api version 2024-04-01 now supports the hub_profile property.
This resource is originally auto generated by pandora, but the generated code for api version 2024-04-01 does not work and needs to be implemented manually.
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_kubernetes_fleet_manager- Add support forhub_profilepropertyThis is a (please select all that apply):
Related Issue(s)
Note
If this PR changes meaningfully during the course of review please update the title and description as required.