azurerm_backup_protected_vm - protection can now be suspended during destroy #27950

katbyte · 2024-11-08T18:35:32Z

Description

add provider feature vm_backup_suspend_protection_and_retain_data_on_destroy

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

provider - support for the vm_backup_suspend_protection_and_retain_data_on_destroy feature [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…destroy

github-actions · 2024-12-16T06:04:00Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

mbfrahry

Hey @katbyte, this looks nearly there except for the test. We'll have to do some work to get this over the finish line and that test passing. After the duplicate provider config is removed, we'll hit the following:

=== CONT  TestAccBackupProtectedVm_protectionSuspendedOnDestroy
    testcase.go:173: Step 4/4 error: Error running apply: exit status 1

        Error: setting protection to BackupsSuspended and retaining data for Protected Item (Subscription: "1a6092a6-137e-4025-9a7c-ef77f76f2c02"
        Resource Group Name: "acctestRG-backup-250107164527989173"
        Vault Name: "acctest-250107164527989173"
        Backup Fabric Name: "Azure"
        Protection Container Name: "iaasvmcontainer;iaasvmcontainerv2;acctestRG-backup-250107164527989173;acctestvm"
        Protected Item Name: "VM;iaasvmcontainerv2;acctestRG-backup-250107164527989173;acctestvm"): protecteditems.ProtectedItemsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="UserErrorOperationDeniedOnImmutableItem" Message="The Vault and Bakcup Item is in Immutable state where destructive operations are not supported. The Vault and Backup Item is immutable, hence operation is denied. Refer to the documentation to learn more: https://aka.ms/AB-ImmutableVaults-States "

    panic.go:629: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: setting protection to BackupsSuspended and retaining data for Protected Item (Subscription: "1a6092a6-137e-4025-9a7c-ef77f76f2c02"
        Resource Group Name: "acctestRG-backup-250107164527989173"
        Vault Name: "acctest-250107164527989173"
        Backup Fabric Name: "Azure"
        Protection Container Name: "iaasvmcontainer;iaasvmcontainerv2;acctestRG-backup-250107164527989173;acctestvm"
        Protected Item Name: "VM;iaasvmcontainerv2;acctestRG-backup-250107164527989173;acctestvm"): protecteditems.ProtectedItemsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="UserErrorOperationDeniedOnImmutableItem" Message="The Vault and Bakcup Item is in Immutable state where destructive operations are not supported. The Vault and Backup Item is immutable, hence operation is denied. Refer to the documentation to learn more: https://aka.ms/AB-ImmutableVaults-States "

--- FAIL: TestAccBackupProtectedVm_protectionSuspendedOnDestroy (242.82s)

internal/services/recoveryservices/backup_protected_vm_resource.go

mbfrahry · 2025-01-08T00:28:39Z

internal/services/recoveryservices/backup_protected_vm_resource_test.go

@@ -1098,6 +1117,21 @@ provider "azurerm" {
 `, r.baseWithOutProvider(data))
 }

+func (r BackupProtectedVmResource) protectionSuspendOnDestroy(data acceptance.TestData) string {
+	return fmt.Sprintf(`
+provider "azurerm" {


This block is causing issues with the test

=== CONT TestAccBackupProtectedVm_protectionSuspendedOnDestroy testcase.go:173: Step 4/4 error: Error running pre-apply plan: exit status 1 Error: Duplicate provider configuration on terraform_plugin_test.tf line 41: 41: provider "azurerm" { A default (non-aliased) provider configuration for "azurerm" was already given at terraform_plugin_test.tf:31,1-19. If multiple configurations are required, set the "alias" argument for alternative configurations. panic.go:626: Error retrieving state, there may be dangling resources: exit status 1 Error: Duplicate provider configuration on terraform_plugin_test.tf line 41: 41: provider "azurerm" { A default (non-aliased) provider configuration for "azurerm" was already given at terraform_plugin_test.tf:31,1-19. If multiple configurations are required, set the "alias" argument for alternative configurations. --- FAIL: TestAccBackupProtectedVm_protectionSuspendedOnDestroy (272.60s)

…e.go Co-authored-by: Matthew Frahry <[email protected]>

mbfrahry

This test is still failing post review updates

=== CONT  TestAccBackupProtectedVm_protectionSuspendedOnDestroy
    testcase.go:173: Step 4/4 error: Error running apply: exit status 1

        Error: setting protection to BackupsSuspended and retaining data for Protected Item (Subscription: "1a6092a6-137e-4025-9a7c-ef77f76f2c02"
        Resource Group Name: "acctestRG-backup-250107164527989173"
        Vault Name: "acctest-250107164527989173"
        Backup Fabric Name: "Azure"
        Protection Container Name: "iaasvmcontainer;iaasvmcontainerv2;acctestRG-backup-250107164527989173;acctestvm"
        Protected Item Name: "VM;iaasvmcontainerv2;acctestRG-backup-250107164527989173;acctestvm"): protecteditems.ProtectedItemsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="UserErrorOperationDeniedOnImmutableItem" Message="The Vault and Bakcup Item is in Immutable state where destructive operations are not supported. The Vault and Backup Item is immutable, hence operation is denied. Refer to the documentation to learn more: https://aka.ms/AB-ImmutableVaults-States "

    panic.go:629: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: setting protection to BackupsSuspended and retaining data for Protected Item (Subscription: "1a6092a6-137e-4025-9a7c-ef77f76f2c02"
        Resource Group Name: "acctestRG-backup-250107164527989173"
        Vault Name: "acctest-250107164527989173"
        Backup Fabric Name: "Azure"
        Protection Container Name: "iaasvmcontainer;iaasvmcontainerv2;acctestRG-backup-250107164527989173;acctestvm"
        Protected Item Name: "VM;iaasvmcontainerv2;acctestRG-backup-250107164527989173;acctestvm"): protecteditems.ProtectedItemsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="UserErrorOperationDeniedOnImmutableItem" Message="The Vault and Bakcup Item is in Immutable state where destructive operations are not supported. The Vault and Backup Item is immutable, hence operation is denied. Refer to the documentation to learn more: https://aka.ms/AB-ImmutableVaults-States "

--- FAIL: TestAccBackupProtectedVm_protectionSuspendedOnDestroy (242.82s)

mbfrahry

I figured out how to get this to work and it requires #27859 to be merged first. I've left a comment in line for what to do

mbfrahry · 2025-01-15T23:27:58Z

internal/services/recoveryservices/backup_protected_vm_resource_test.go

+
+	data.ResourceTest(t, r, []acceptance.TestStep{
+		{
+			Config: r.basic(data),


Once #27859 is merged, we can update to use a new config here that uses an immutable vault as we can't suspend protection without an immutable vault.

sreallymatt

Thanks @mbfrahry / @katbyte - left 2 minor comments, and there seems to be a linting error

internal/provider/framework/config_test.go

sreallymatt

LGTM!

stale

* Update for #27950 * Update for #27824 * Update for #28592 #28583 #28599 #28590 #28453 * Update #28528 * Update for #27853 * Update CHANGELOG.md #28221 * Update for #27760 * Update CHANGELOG.md #28480 * Update CHANGELOG.md typo * Update CHANGELOG.md #28372 * Update CHANGELOG.md for #26047 also alphabetised ENHANCEMENTS * Update for #28146 * Update CHANGELOG.md #28013 * Update CHANGELOG.md for #28492 * Update CHANGELOG.md for #28648 * Update CHANGELOG.md for #28549 * Update for #28469 #28620 * prep for release * i touched it last --------- Co-authored-by: catriona-m <[email protected]> Co-authored-by: jackofallops <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>

azurerm_backup_protected_vm - protection can now be suspended during …

bdc4b44

…destroy

katbyte requested a review from a team as a code owner November 8, 2024 18:35

github-actions bot added documentation service/recovery-services size/L labels Nov 8, 2024

make terrafmt

4c42aa1

github-actions bot added the waiting-response label Nov 8, 2024

rcskosir added the enhancement label Nov 8, 2024

github-actions bot added the stale label Dec 16, 2024

katbyte added 2 commits December 26, 2024 10:57

Merge branch 'main' into kt/recserv-vm-backup-suspend

47eb18b

fix unit tests

4fd0e14

github-actions bot added waiting-response and removed waiting-response labels Dec 26, 2024

fix unit tests

1e39d50

github-actions bot removed the waiting-response label Dec 26, 2024

mbfrahry requested changes Jan 8, 2025

View reviewed changes

github-actions bot assigned mbfrahry Jan 8, 2025

github-actions bot added the waiting-response label Jan 8, 2025

Update internal/services/recoveryservices/backup_protected_vm_resourc…

3f612c3

…e.go Co-authored-by: Matthew Frahry <[email protected]>

github-actions bot removed the waiting-response label Jan 8, 2025

fix test with duplicate azurerm provider block

242bf3b

mbfrahry requested changes Jan 15, 2025

View reviewed changes

github-actions bot added waiting-response and removed stale labels Jan 15, 2025

mbfrahry previously requested changes Jan 15, 2025

View reviewed changes

mbfrahry added 2 commits January 15, 2025 15:56

Merge branch 'main' into kt/recserv-vm-backup-suspend

ec513e0

Fix TestAccBackupProtectedVm_protectionSuspendedOnDestroy

b987db5

github-actions bot removed waiting-response size/L labels Jan 16, 2025

github-actions bot added size/XL waiting-response labels Jan 16, 2025

sreallymatt reviewed Jan 16, 2025

View reviewed changes

internal/provider/framework/config_test.go Outdated Show resolved Hide resolved

internal/provider/framework/config_test.go Outdated Show resolved Hide resolved

Address review

de10972

github-actions bot removed the waiting-response label Jan 16, 2025

sreallymatt approved these changes Jan 16, 2025

View reviewed changes

stephybun merged commit d40831d into main Jan 21, 2025
33 checks passed

stephybun deleted the kt/recserv-vm-backup-suspend branch January 21, 2025 10:02

github-actions bot added this to the v4.17.0 milestone Jan 21, 2025

stephybun added a commit that referenced this pull request Jan 21, 2025

Update for #27950

e006c57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

azurerm_backup_protected_vm - protection can now be suspended during destroy #27950

azurerm_backup_protected_vm - protection can now be suspended during destroy #27950

katbyte commented Nov 8, 2024

github-actions bot commented Dec 16, 2024

mbfrahry left a comment

mbfrahry Jan 8, 2025

mbfrahry left a comment

mbfrahry left a comment

mbfrahry Jan 15, 2025

sreallymatt left a comment

sreallymatt left a comment

azurerm_backup_protected_vm - protection can now be suspended during destroy #27950

azurerm_backup_protected_vm - protection can now be suspended during destroy #27950

Conversation

katbyte commented Nov 8, 2024

Description

Change Log

Related Issue(s)

github-actions bot commented Dec 16, 2024

mbfrahry left a comment

Choose a reason for hiding this comment

mbfrahry Jan 8, 2025

Choose a reason for hiding this comment

mbfrahry left a comment

Choose a reason for hiding this comment

mbfrahry left a comment

Choose a reason for hiding this comment

mbfrahry Jan 15, 2025

Choose a reason for hiding this comment

sreallymatt left a comment

Choose a reason for hiding this comment

sreallymatt left a comment

Choose a reason for hiding this comment