Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_healthcare_dicom_service resource & data source - support for new properties #27375

Merged
merged 16 commits into from
Jan 9, 2025
Merged

azurerm_healthcare_dicom_service resource & data source - support for new properties #27375

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
89385bf
add several properties for healthcareapi dicomservice
hqhqhqhqhqhqhqhqhqhqhq Sep 12, 2024
a7230a0
Update healthcare_dicom_data_source.go
hqhqhqhqhqhqhqhqhqhqhq Sep 12, 2024
8605ae6
fix issues addressed in review
hqhqhqhqhqhqhqhqhqhqhq Sep 24, 2024
dbc59ff
Update healthcare_dicom_data_source.go
hqhqhqhqhqhqhqhqhqhqhq Sep 30, 2024
3abe99f
Update docs
hqhqhqhqhqhqhqhqhqhqhq Sep 30, 2024
b99e007
Update resource & data source & test
hqhqhqhqhqhqhqhqhqhqhq Sep 30, 2024
4506f14
fix: extend error message
hqhqhqhqhqhqhqhqhqhqhq Sep 30, 2024
fff7a9e
Update healthcare_dicom_resource_test.go
hqhqhqhqhqhqhqhqhqhqhq Sep 30, 2024
005ae2a
Merge remote-tracking branch 'upstream/main' into feat/healthcare_api…
hqhqhqhqhqhqhqhqhqhqhq Nov 6, 2024
06a0e6c
Update healthcare_dicom_data_source.go
hqhqhqhqhqhqhqhqhqhqhq Nov 6, 2024
e43efe8
Update healthcare_dicom_data_source.go
hqhqhqhqhqhqhqhqhqhqhq Nov 6, 2024
c967bc5
fix: update url to URL for API Response
hqhqhqhqhqhqhqhqhqhqhq Nov 8, 2024
a6b433a
Update healthcare_dicom_resource_test.go
hqhqhqhqhqhqhqhqhqhqhq Nov 8, 2024
cb06e2d
Update healthcare_dicom_resource.go
hqhqhqhqhqhqhqhqhqhqhq Dec 12, 2024
c84092d
Update healthcare_dicom_resource.go
hqhqhqhqhqhqhqhqhqhqhq Dec 12, 2024
dbf0e42
Merge remote-tracking branch 'upstream/main' into feat/healthcare_api…
hqhqhqhqhqhqhqhqhqhqhq Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 104 additions & 0 deletions internal/services/healthcare/healthcare_dicom_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"fmt"
"time"

"github.com/hashicorp/go-azure-helpers/lang/pointer"
"github.com/hashicorp/go-azure-helpers/lang/response"
"github.com/hashicorp/go-azure-helpers/resourcemanager/commonschema"
"github.com/hashicorp/go-azure-helpers/resourcemanager/identity"
Expand Down Expand Up @@ -54,6 +55,7 @@ func dataSourceHealthcareDicomService() *pluginsdk.Resource {
Type: pluginsdk.TypeString,
Computed: true,
},

"audience": {
Type: pluginsdk.TypeList,
Computed: true,
Expand Down Expand Up @@ -86,6 +88,86 @@ func dataSourceHealthcareDicomService() *pluginsdk.Resource {
Computed: true,
},

"data_partitions_enabled": {
Type: pluginsdk.TypeBool,
Computed: true,
},

"cors": {
Type: pluginsdk.TypeList,
Computed: true,
Elem: &pluginsdk.Resource{
Schema: map[string]*pluginsdk.Schema{
"allowed_origins": {
Type: pluginsdk.TypeList,
Computed: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
},
},

"allowed_headers": {
Type: pluginsdk.TypeList,
Computed: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
},
},

"allowed_methods": {
Type: pluginsdk.TypeList,
Computed: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
},
},

"max_age_in_seconds": {
Type: pluginsdk.TypeInt,
Computed: true,
},

"allow_credentials": {
Type: pluginsdk.TypeBool,
Computed: true,
},
},
},
},

"encryption_key_url": {
Type: pluginsdk.TypeString,
Computed: true,
},

"storage": {
Type: pluginsdk.TypeList,
Computed: true,
Elem: &pluginsdk.Resource{
Schema: map[string]*pluginsdk.Schema{
"file_system_name": {
Type: pluginsdk.TypeString,
Computed: true,
},

"storage_account_id": {
Type: pluginsdk.TypeString,
Computed: true,
},
},
},
},

"provision_state": {
Type: pluginsdk.TypeString,
Computed: true,
},

"event_state": {
Type: pluginsdk.TypeString,
Computed: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields contain transient information that isn't meaningful to users, we don't usually expose these in resources or data sources

Suggested change
"provision_state": {
Type: pluginsdk.TypeString,
Computed: true,
},
"event_state": {
Type: pluginsdk.TypeString,
Computed: true,
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this has been removed from the data source and the docs


"tags": commonschema.TagsDataSource(),
},
}
Expand Down Expand Up @@ -123,6 +205,28 @@ func dataSourceHealthcareApisDicomServiceRead(d *pluginsdk.ResourceData, meta in
d.Set("authentication", flattenDicomAuthentication(props.AuthenticationConfiguration))
d.Set("private_endpoint", flattenDicomServicePrivateEndpoint(props.PrivateEndpointConnections))
d.Set("service_url", props.ServiceUrl)

enableDataPartitions := false
if props.EnableDataPartitions != nil {
enableDataPartitions = pointer.From(props.EnableDataPartitions)
}
d.Set("data_partitions_enabled", enableDataPartitions)

d.Set("cors", flattenDicomServiceCorsConfiguration(props.CorsConfiguration))

if props.Encryption != nil && props.Encryption.CustomerManagedKeyEncryption != nil {
d.Set("encryption_key_url", pointer.From(props.Encryption.CustomerManagedKeyEncryption.KeyEncryptionKeyUrl))
}

d.Set("storage", flattenStorageConfiguration(props.StorageConfiguration))

if props.ProvisioningState != nil {
d.Set("provision_state", pointer.From(props.ProvisioningState))
}

if props.EventState != nil {
d.Set("event_state", pointer.From(props.EventState))
}
}

i, err := identity.FlattenLegacySystemAndUserAssignedMap(m.Identity)
Expand Down
Loading
Loading