azurerm_spring_cloud_api_portal - split to create/update functions

[ms-henglu]

=== RUN   TestAccSpringCloudAPIPortal_basic
=== PAUSE TestAccSpringCloudAPIPortal_basic
=== CONT  TestAccSpringCloudAPIPortal_basic
=== RUN   TestAccSpringCloudAPIPortal_requiresImport
=== PAUSE TestAccSpringCloudAPIPortal_requiresImport
=== CONT  TestAccSpringCloudAPIPortal_requiresImport
=== RUN   TestAccSpringCloudAPIPortal_complete
=== PAUSE TestAccSpringCloudAPIPortal_complete
=== CONT  TestAccSpringCloudAPIPortal_complete
=== RUN   TestAccSpringCloudAPIPortal_update
=== PAUSE TestAccSpringCloudAPIPortal_update
=== CONT  TestAccSpringCloudAPIPortal_update
--- PASS: TestAccSpringCloudAPIPortal_requiresImport (846.38s)
--- PASS: TestAccSpringCloudAPIPortal_update (849.44s)
--- PASS: TestAccSpringCloudAPIPortal_complete (904.65s)
--- PASS: TestAccSpringCloudAPIPortal_basic (1033.62s)
PASS

[stephybun]

Thanks @ms-henglu. Tests look fine, but there are some typos in the error messages.

[stephybun]

This is misspelled multiple times, please fix all of them

Suggested change

	return fmt.Errorf("retreiving %s: %+v", id, err)
	return fmt.Errorf("retrieving %s: %+v", id, err)

[stephybun]

The error messaged in the create function also need to be updated.

Suggested change

	return fmt.Errorf("creating/updating %s: %+v", id, err)
	}
	if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {
	return fmt.Errorf("waiting for creation/update of %s: %+v", id, err)
	return fmt.Errorf("updating %s: %+v", id, err)
	}
	if err := future.WaitForCompletionRef(ctx, client.Client); err != nil {
	return fmt.Errorf("waiting for update of %s: %+v", id, err)

[ms-henglu]

Hi @stephybun ,

Thanks for the code review! I've updated this PR as suggested, please take another look.

[stephybun]

Thanks @ms-henglu LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.