Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redisenterprise: updating to API Version 2023-11-01 #23865

Closed
wants to merge 3 commits into from

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Nov 10, 2023

This PR updates redisenterprise to use API Version 2023-11-01 from API Versions 2023-07-01 and 2023-10-01-preview

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Nov 13, 2023
@tombuildsstuff
Copy link
Contributor Author

Looks like this API version isn't rolled out fully yet:

 Error: waiting for creation of Redis Enterprise (Subscription: "*******"
        Resource Group Name: "acctestRG-redisEnterprise-231110163233435734"
        Redis Enterprise Name: "acctest-rec-231110163233435734"): performing Create: unexpected status 400 with error: NoRegisteredProviderFound: No registered resource provider found for location 'eastus' and API version '2023-11-01' for type 'redisEnterprise'. The supported api-versions are '2023-10-01-preview, 2023-07-01, 2023-03-01-preview, 2022-11-01-preview, 2022-01-01, 2021-08-01, 2021-03-01, 2021-02-01-preview, 2020-04-01-preview, 2020-10-01-preview'. The supported locations are 'eastus, westeurope, westus, eastus2, westus2, westus3, northcentralus, southcentralus, uksouth, southeastasia, australiaeast, northeurope, centralus, centralindia, westcentralus, canadacentral, brazilsouth, japaneast, eastasia'.

@tombuildsstuff tombuildsstuff modified the milestones: v3.81.0, Blocked Nov 13, 2023
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚖️

@tombuildsstuff
Copy link
Contributor Author

Still blocked on the Azure API not being rolled out, when apiVersions from the below command contains 2023-11-01 this should be good to go/run the tests:

az rest --method get --url "/subscriptions/XXX/providers/Microsoft.Cache?api-version=2020-01-01" --query "resourceTypes[?resourceType=='redisEnterprise/databases'].{resourceType:resourceType,apiVersions:apiVersions}"

@tombuildsstuff
Copy link
Contributor Author

Still hasn't been deployed - closing for now.

@tombuildsstuff tombuildsstuff deleted the f/updating-redisenterprise-to-2023-11-01 branch December 12, 2023 09:41
Copy link

github-actions bot commented May 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies service/redis size/L upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants