azurerm_windows_web_app,azurerm_windows_web_app_slot,azurerm_windows_function_app,azurerm_windows_function_app_slot - add push_setting feature.

[xiaxyi]

Add push feature for windows apps.

acc tests:

--- PASS: TestAccWindowsFunctionApp_withPush (838.18s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    838.951s
--- PASS: TestAccWindowsWebApp_push (783.80s)
--- PASS: TestAccWindowsWebApp_pushUpdate (1252.96s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    1253.777s

[jackofallops]

Hi @xiaxyi
Thanks for this PR. I've left some comments below on the implementation / design of this property and how it's used. Can you take a look?

Thanks!

[jackofallops]

The presence of this block should be used define this value?

[jackofallops]

Suggested change

	},
	"tags_to_whitelist": {
	},
	"tags_to_whitelist": {

[jackofallops]

I feel this should be a schema property, specifically the ID of the notification hub, and not a value in the app_settings map so we can validate it, and retrieve the name value from the resource? This will allow terraform to correctly plan the dependencies, and will also better inform users that this is required, rather than expecting users to know this needs adding here?

[katbyte]

@xiaxyi - i'm going to close this out as its been sitting here for a number of months, please do reopen it once you are ready to continue working on it. thanks

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.