Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/resource: Go documentation intentions for ErrorCheck and ExpectError #242

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 7, 2023

Sorry meant to include this with #238

This is a quick followup recent clarification changes in error messages to better mention intended use and message compatibility with TestCase.ErrorCheck and TestStep.ExpectError.

…tError

Reference: #238

This is a quick followup recent clarification changes in error messages to better mention intended use and message compatibility with `TestCase.ErrorCheck` and `TestStep.ExpectError`.
@bflad bflad added the documentation Improvements or additions to documentation label Dec 7, 2023
@bflad bflad added this to the v1.7.0 milestone Dec 7, 2023
@bflad bflad requested a review from a team as a code owner December 7, 2023 14:29
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad merged commit aba4754 into main Dec 7, 2023
25 checks passed
@bflad bflad deleted the bflad/mention-error-messaging-compatibility branch December 7, 2023 15:18
Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants